Support CC/BCC importing on rfc822 #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only To was supported on rfc822 importing and Cc/Bcc was silently dropped. This change adds support (and related test) for these two fields. Signed-off-by: Dave Walker (Daviey) <[email protected]>
|
Oh Dang, i see you literally just cut 0.5.10. |
lavr
reviewed
Sep 27, 2016
| @@ -260,6 +260,9 @@ def _build_root_message(self, message_cls=None, **kw): | |||
| if self.cc: | |||
| self.set_header(msg, 'Cc', ", ".join([self.encode_address_header(addr) for addr in self.cc]), encode=False) | |||
|
|
|||
| if self.bcc: | |||
There was a problem hiding this comment.
I thought Bcc should be used in SMTP MAIL TO command only.
Is there any reason to include it in message headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only To was supported on rfc822 importing and
Cc/Bcc was silently dropped.
This change adds support (and related test) for these two
fields.
Signed-off-by: Dave Walker (Daviey) [email protected]